From 14ff7cb3b080b4a0f26e4982d30e1c32785ad6ee Mon Sep 17 00:00:00 2001
From: Robin Cheney <cheneyr@eternal.ddnss.de>
Date: Fri, 21 Nov 2025 15:06:21 +0100
Subject: [PATCH] ui redesign

---
 .../tankstelle/FuelStation.java               |  4 +++
 .../tankstelle/LargeFuelStation.java          |  4 +++
 .../tankstelle/MediumFuelStation.java         |  4 +++
 .../tankstelle/SmallFuelStation.java          |  4 +++
 .../controllers/FuelStationUIController.java  |  9 +++----
 src/main/resources/ui/FuelStationUI.fxml      |  8 +++---
 src/main/resources/ui/NewStationTab.fxml      |  6 ++---
 src/main/resources/ui/PriceTab.fxml           | 23 +++++++++--------
 src/main/resources/ui/ResultTab.fxml          |  6 ++---
 src/main/resources/ui/StockTab.fxml           | 25 ++++++++-----------
 10 files changed, 53 insertions(+), 40 deletions(-)

diff --git a/src/main/java/de/diejungsvondertanke/tankstelle/FuelStation.java b/src/main/java/de/diejungsvondertanke/tankstelle/FuelStation.java
index a3c6042..ac8f122 100644
--- a/src/main/java/de/diejungsvondertanke/tankstelle/FuelStation.java
+++ b/src/main/java/de/diejungsvondertanke/tankstelle/FuelStation.java
@@ -260,4 +260,8 @@ public abstract class FuelStation {
         }
         throw new NoSuchFuelTypeError("This fuel station does not have fuel of the given type");
     }
+
+    public String getSimpleName() {
+        return null;
+    }
 }
\ No newline at end of file
diff --git a/src/main/java/de/diejungsvondertanke/tankstelle/LargeFuelStation.java b/src/main/java/de/diejungsvondertanke/tankstelle/LargeFuelStation.java
index b2a95c3..ed4ab66 100644
--- a/src/main/java/de/diejungsvondertanke/tankstelle/LargeFuelStation.java
+++ b/src/main/java/de/diejungsvondertanke/tankstelle/LargeFuelStation.java
@@ -42,4 +42,8 @@ public class LargeFuelStation extends FuelStation {
     public String getSupermarket_company() {
         return supermarket_company;
     }
+
+    public String getSimpleName() {
+        return "large fuel station";
+    }
 }
diff --git a/src/main/java/de/diejungsvondertanke/tankstelle/MediumFuelStation.java b/src/main/java/de/diejungsvondertanke/tankstelle/MediumFuelStation.java
index ff6636f..2ce9cc4 100644
--- a/src/main/java/de/diejungsvondertanke/tankstelle/MediumFuelStation.java
+++ b/src/main/java/de/diejungsvondertanke/tankstelle/MediumFuelStation.java
@@ -41,4 +41,8 @@ public class MediumFuelStation extends FuelStation {
     public float getRetail_space() {
         return retail_space;
     }
+
+    public String getSimpleName() {
+        return "medium fuel station";
+    }
 }
diff --git a/src/main/java/de/diejungsvondertanke/tankstelle/SmallFuelStation.java b/src/main/java/de/diejungsvondertanke/tankstelle/SmallFuelStation.java
index e5f1e24..3abce91 100644
--- a/src/main/java/de/diejungsvondertanke/tankstelle/SmallFuelStation.java
+++ b/src/main/java/de/diejungsvondertanke/tankstelle/SmallFuelStation.java
@@ -40,4 +40,8 @@ public class SmallFuelStation extends FuelStation {
     public short getNumber_of_vending_machines() {
         return number_of_vending_machines;
     }
+
+    public String getSimpleName() {
+        return "small fuel station";
+    }
 }
diff --git a/src/main/java/de/diejungsvondertanke/tankstelle/controllers/FuelStationUIController.java b/src/main/java/de/diejungsvondertanke/tankstelle/controllers/FuelStationUIController.java
index 9f4d1d4..a95b2a0 100644
--- a/src/main/java/de/diejungsvondertanke/tankstelle/controllers/FuelStationUIController.java
+++ b/src/main/java/de/diejungsvondertanke/tankstelle/controllers/FuelStationUIController.java
@@ -36,13 +36,12 @@ public class FuelStationUIController {
     @FXML
     private HBox resultTabContainer;
     @FXML
-    private GridPane priceTabContainer;
+    private VBox priceTabContainer;
     @FXML
-    private GridPane stockTabContainer;
+    private VBox stockTabContainer;
     @FXML
     private HBox searchTabContainer;
     @FXML
-    // private GridPane newStationTabContainer;
     private VBox newStationTabContainer;
     @FXML
     private BorderPane overviewTabContainer;
@@ -169,9 +168,9 @@ public class FuelStationUIController {
     public String getDisplayName(FuelStation fs) {
         int index = Main.fuelStations.indexOf(fs);
         if (index >= 0) {
-            return "Station " + (index + 1) + " (" + fs.getClass().getSimpleName() + ")";
+            return "Station " + (index + 1) + " (" + fs.getSimpleName() + ")";
         }
-        return fs.getClass().getSimpleName();
+        return fs.getSimpleName();
     }
 
     public void appendOutput(String text) {
diff --git a/src/main/resources/ui/FuelStationUI.fxml b/src/main/resources/ui/FuelStationUI.fxml
index e8727d2..0f72841 100644
--- a/src/main/resources/ui/FuelStationUI.fxml
+++ b/src/main/resources/ui/FuelStationUI.fxml
@@ -14,9 +14,9 @@
                 <Insets top="10" right="10" bottom="10" left="10" />
             </padding>
             <Label text="Fuel station:" />
-            <ComboBox fx:id="comboFuelStations" prefWidth="200" />
+            <ComboBox fx:id="comboFuelStations" />
             <Label text="Fuel type:" />
-            <ComboBox fx:id="comboFuelTypes" prefWidth="150" />
+            <ComboBox fx:id="comboFuelTypes" />
         </HBox>
     </top>
 
@@ -28,10 +28,10 @@
                     <HBox fx:id="resultTabContainer" />
                 </Tab>
                 <Tab text="Change price" closable="false">
-                    <GridPane fx:id="priceTabContainer" />
+                    <VBox fx:id="priceTabContainer" />
                 </Tab>
                 <Tab text="Change stock" closable="false">
-                    <GridPane fx:id="stockTabContainer" />
+                    <VBox fx:id="stockTabContainer" />
                 </Tab>
                 <Tab text="Search" closable="false">
                     <HBox fx:id="searchTabContainer" />
diff --git a/src/main/resources/ui/NewStationTab.fxml b/src/main/resources/ui/NewStationTab.fxml
index a854533..6a84a41 100644
--- a/src/main/resources/ui/NewStationTab.fxml
+++ b/src/main/resources/ui/NewStationTab.fxml
@@ -18,13 +18,13 @@
               <fx:define>
                      <ToggleGroup fx:id="group" />
               </fx:define>
-              <RadioButton fx:id="rbSmall" text="Small" selected="true"
+              <RadioButton fx:id="rbSmall" text="Small " selected="true"
                      toggleGroup="$group"
                      onAction="#setAttributeTypeFromSmallStation" />
-              <RadioButton fx:id="rbMedium" text="Medium"
+              <RadioButton fx:id="rbMedium" text="Medium "
                      toggleGroup="$group"
                      onAction="#setAttributeTypeFromMediumStation" />
-              <RadioButton fx:id="rbLarge" text="Large"
+              <RadioButton fx:id="rbLarge" text="Large "
                      toggleGroup="$group"
                      onAction="#setAttributeTypeFromLargeStation" />
 
diff --git a/src/main/resources/ui/PriceTab.fxml b/src/main/resources/ui/PriceTab.fxml
index c8acfdc..f8190ac 100644
--- a/src/main/resources/ui/PriceTab.fxml
+++ b/src/main/resources/ui/PriceTab.fxml
@@ -3,17 +3,18 @@
 <?import javafx.scene.layout.*?>
 <?import javafx.scene.control.*?>
 
-<GridPane xmlns:fx="http://javafx.com/fxml"
-    fx:controller="de.diejungsvondertanke.tankstelle.controllers.PriceTabController"
-    hgap="10" vgap="10">
-    <padding>
-        <Insets top="15" right="15" bottom="15" left="15"/>
-    </padding>
+<VBox xmlns:fx="http://javafx.com/fxml"
+    fx:controller="de.diejungsvondertanke.tankstelle.controllers.PriceTabController">
+    <HBox VBox.vgrow="ALWAYS" spacing="10">
 
-    <Label text="New price (€/L):" GridPane.rowIndex="0" GridPane.columnIndex="0" />
-    <TextField fx:id="txtPrice" GridPane.rowIndex="0" GridPane.columnIndex="1" />
+        <padding>
+            <Insets top="15" right="15" bottom="15" left="15" />
+        </padding>
 
-    <Button text="Change price" onAction="#save"
-        GridPane.rowIndex="1" GridPane.columnIndex="0" GridPane.columnSpan="2" />
+        <Label text="New price (€ / L):" />
+        <TextField fx:id="txtPrice" />
 
-</GridPane>
\ No newline at end of file
+        <Button text="Change price" onAction="#save" />
+    </HBox>
+
+</VBox>
\ No newline at end of file
diff --git a/src/main/resources/ui/ResultTab.fxml b/src/main/resources/ui/ResultTab.fxml
index 1703f2c..4a56d6d 100644
--- a/src/main/resources/ui/ResultTab.fxml
+++ b/src/main/resources/ui/ResultTab.fxml
@@ -5,7 +5,7 @@
 
 <HBox xmlns:fx="http://javafx.com/fxml"
     fx:controller="de.diejungsvondertanke.tankstelle.controllers.ResultTabController"
-    spacing="20">
+    spacing="20" HBox.hgrow="ALWAYS">
     <padding>
         <Insets top="15" right="15" bottom="15" left="15" />
     </padding>
@@ -18,9 +18,9 @@
         <Button text="Total stock (selection)" onAction="#handleTotalStock" />
     </VBox>
 
-    <VBox spacing="10">
+    <VBox spacing="10" HBox.hgrow="ALWAYS">
         <Label text="Fuel station selection (multiple):" />
-        <ListView fx:id="listFuelStations" prefWidth="220" />
+        <ListView fx:id="listFuelStations" HBox.hgrow="ALWAYS" />
     </VBox>
 
 </HBox>
\ No newline at end of file
diff --git a/src/main/resources/ui/StockTab.fxml b/src/main/resources/ui/StockTab.fxml
index 5f5501c..f977136 100644
--- a/src/main/resources/ui/StockTab.fxml
+++ b/src/main/resources/ui/StockTab.fxml
@@ -3,21 +3,18 @@
 <?import javafx.scene.control.*?>
 <?import javafx.scene.layout.*?>
 
-<GridPane xmlns:fx="http://javafx.com/fxml"
-      fx:controller="de.diejungsvondertanke.tankstelle.controllers.StockTabController"
-      hgap="10" vgap="10">
+<VBox xmlns:fx="http://javafx.com/fxml"
+      fx:controller="de.diejungsvondertanke.tankstelle.controllers.StockTabController"  spacing="10">
       <padding>
-            <Insets top="15" right="15" bottom="15" left="15"/>
+            <Insets top="15" right="15" bottom="15" left="15" />
       </padding>
+      <HBox>
+            <Label text="Amount (L): " />
+            <TextField fx:id="txtAmount" />
+      </HBox>
 
-      <Label text="Amount (L):" GridPane.rowIndex="0" GridPane.columnIndex="0" />
-      <TextField fx:id="txtAmount" GridPane.rowIndex="0" GridPane.columnIndex="1" />
+      <RadioButton fx:id="rbAbsolute" text="Set absolute" selected="true" />
+      <RadioButton fx:id="rbDelta" text="Change (+/-)" />
 
-      <RadioButton fx:id="rbAbsolute" text="Set absolute" selected="true"
-            GridPane.rowIndex="1" GridPane.columnIndex="0" GridPane.columnSpan="2" />
-      <RadioButton fx:id="rbDelta" text="Change (+/-)"
-            GridPane.rowIndex="2" GridPane.columnIndex="0" GridPane.columnSpan="2" />
-
-      <Button text="Change stock" onAction="#save"
-            GridPane.rowIndex="3" GridPane.columnIndex="0" GridPane.columnSpan="2" />
-</GridPane>
\ No newline at end of file
+      <Button text="Change stock" onAction="#save" />
+</VBox>
\ No newline at end of file
-- 
2.43.0